Why not just fix the site?
02-08-18, 05:02 PM
#101
DVD Talk Legend
Re: Why not just fix the site?
I can confirm that I do have 400 now. Thanks, IBJoel.
02-28-18, 07:01 AM
#103
DVD Talk Hero
08-05-18, 07:34 AM
#104
DVD Talk Hero
08-06-18, 03:59 PM
#105
Administrator
Re: Why not just fix the site?
Thanks Nick, I've deleted those threads.
09-03-18, 06:31 AM
#106
DVD Talk Hero
Re: Why not just fix the site?
09-03-18, 07:16 AM
#107
DVD Talk Reviewer/ Admin
Join Date: Sep 1999
Location: Greenville, South Cackalack
Posts: 28,842
Received 1,889 Likes
on
1,241 Posts
Re: Why not just fix the site?
Code:
if (is_array($dailyReviews))
{
...
}
Code:
if (is_array($dailyReviews) && count($dailyReviews))
{
...
}
else
{
die("Nothing to post!\n");
// Or, alternatively, just a plain ol' exit;
}
Last edited by Adam Tyner; 09-03-18 at 07:31 AM.
09-03-18, 07:17 AM
#108
Challenge Guru & Comic Nerd
Re: Why not just fix the site?
Why are we worried about fixing a non-problem? The blank threads are actually useful, verifying that there are no new reviews that morning.
09-03-18, 07:21 AM
#109
DVD Talk Reviewer/ Admin
Join Date: Sep 1999
Location: Greenville, South Cackalack
Posts: 28,842
Received 1,889 Likes
on
1,241 Posts
Re: Why not just fix the site?
Code:
if (is_array($dailyReviews))
{
...
}
Code:
if (is_array($dailyReviews) && count($dailyReviews))
{
...
}
else
{
$post = "No new reviews have been published today. Sorry!";
}
09-03-18, 09:06 AM
#111
Moderator
Thread Starter
Re: Why not just fix the site?
"Why not just fix the site? (Why can’t we just put Adam in charge?)" could make for a good thread title change. 
11-18-18, 06:16 AM
#114
DVD Talk Hero
Re: Why not just fix the site?
https://forum.dvdtalk.com/dvd-review...l#post13445934
I'm done with the experiment.
11-18-18, 07:58 AM
#115
Challenge Guru & Comic Nerd
Re: Why not just fix the site?
Yep, dozens of those blank threads in the past year. There are almost a dozen blank threads in that forum’s first page right now. Possible easy and quite useful fix offered by Adam over two months ago. IB response?
11-19-18, 09:56 AM
#116
Administrator
Re: Why not just fix the site?
The blank threads are an indication of no new reviews being posted for that day, just as Trevor said. The reason it has not been "fixed" is because it is not a bug.
11-19-18, 10:01 AM
#117
DVD Talk Reviewer/ Admin
Join Date: Sep 1999
Location: Greenville, South Cackalack
Posts: 28,842
Received 1,889 Likes
on
1,241 Posts
Re: Why not just fix the site?
As the person who originally wrote that script, it is a bug. The blank threads don’t even have titles to click on.
11-19-18, 10:02 AM
#118
DVD Talk Legend
11-19-18, 10:10 AM
#119
Challenge Guru & Comic Nerd
Re: Why not just fix the site?
The new definition of ‘facts’ is having a trickle down effect on the country. A way to fix it was detailed by Adam months ago. It’d be a nice fix for the community, and looks pretty simple. Can you either fix it, or tell us that some technical reason prohibits it?
11-19-18, 10:16 AM
#120
DVD Talk Reviewer/ Admin
Join Date: Sep 1999
Location: Greenville, South Cackalack
Posts: 28,842
Received 1,889 Likes
on
1,241 Posts
Re: Why not just fix the site?
I can stop the blank threads from being created. The cron was wiped out during a server change a few years back, so I’m executing these scripts remotely from my own server. I can’t update the code, but I control when things run. I can have a script check the RSS feed for new reviews and only execute the daily review script when needed.
That won’t fix the other issue where Ultra HD Blu-ray reviews don’t appear in the list. Maybe I can write something to simulate a login and create these threads differently.
That won’t fix the other issue where Ultra HD Blu-ray reviews don’t appear in the list. Maybe I can write something to simulate a login and create these threads differently.
11-19-18, 10:19 AM
#121
DVD Talk Legend
Re: Why not just fix the site?
That seems like a lot of effort for something that isn't a bug. 
11-19-18, 12:19 PM
#122
DVD Talk Reviewer/ Admin
Join Date: Sep 1999
Location: Greenville, South Cackalack
Posts: 28,842
Received 1,889 Likes
on
1,241 Posts
Re: Why not just fix the site?
I have an improved daily recap system in place now.
Example with review content
Example without review content
Example with review content
Example without review content
11-19-18, 12:48 PM
#124
Premium Member
Join Date: Jan 2000
Location: Grazing in a field somewhere...
Posts: 23,654
Received 708 Likes
on
469 Posts
Re: Why not just fix the site?
While we're at it... There's a nice "Buy Stuff Here" link at the top-right corner of the site (link below). Most of the links on that page are dead and have been for a long time. If there are actually some affiliate links that work, it would be nice to update that page (get rid of the dead crap), and maybe promote that once in a while to help with revenue.
https://www.dvdtalk.com/support.html
https://www.dvdtalk.com/support.html
11-20-18, 12:01 PM
#125
Administrator
Re: Why not just fix the site?
While we're at it... There's a nice "Buy Stuff Here" link at the top-right corner of the site (link below). Most of the links on that page are dead and have been for a long time. If there are actually some affiliate links that work, it would be nice to update that page (get rid of the dead crap), and maybe promote that once in a while to help with revenue.
https://www.dvdtalk.com/support.html
https://www.dvdtalk.com/support.html
