Forum Feedback and Support Post forum feedback and related problems, here.

Why not just fix the site?

Old 02-08-18, 06:02 PM
  #101  
DVD Talk Legend
 
Norm de Plume's Avatar
 
Join Date: Dec 2000
Location: Toronto
Posts: 14,351
Re: Why not just fix the site?

I can confirm that I do have 400 now. Thanks, IBJoel.
Norm de Plume is offline  
Old 02-08-18, 06:20 PM
  #102  
DVD Talk Hero
 
davidh777's Avatar
 
Join Date: Oct 2003
Location: Home of 2013 NFL champion Seahawks
Posts: 40,513
Re: Why not just fix the site?

And I'm up to 1000. Thanks!
davidh777 is online now  
Old 02-28-18, 08:01 AM
  #103  
DVD Talk Legend
 
Nick Danger's Avatar
 
Join Date: Mar 2001
Location: Albuquerque
Posts: 21,321
Re: Why not just fix the site?

Originally Posted by IBtyen View Post
Instead of removing these blank threads, can you alert us in this thread or send one of us a PM? It will help us to have a live example so we can take it to our tech team.
https://forum.dvdtalk.com/dvd-review...l#post13279426
Nick Danger is offline  
Old 08-05-18, 08:34 AM
  #104  
DVD Talk Legend
 
Nick Danger's Avatar
 
Join Date: Mar 2001
Location: Albuquerque
Posts: 21,321
Re: Why not just fix the site?

Originally Posted by IBtyen View Post
Instead of removing these blank threads, can you alert us in this thread or send one of us a PM? It will help us to have a live example so we can take it to our tech team.
https://forum.dvdtalk.com/dvd-review...l#post13384255
Nick Danger is offline  
Old 08-06-18, 04:59 PM
  #105  
Administrator
 
Join Date: Sep 2015
Posts: 403
Re: Why not just fix the site?

Thanks Nick, I've deleted those threads.
IBJoel is offline  
Old 09-03-18, 07:31 AM
  #106  
DVD Talk Legend
 
Nick Danger's Avatar
 
Join Date: Mar 2001
Location: Albuquerque
Posts: 21,321
Re: Why not just fix the site?

Originally Posted by IBJoel View Post
Thanks Nick, I've deleted those threads.
Have you addressed the underlying problem?

https://forum.dvdtalk.com/dvd-review...l#post13400886
Nick Danger is offline  
Old 09-03-18, 08:16 AM
  #107  
DVD Talk Reviewer/ Admin
 
Adam Tyner's Avatar
 
Join Date: Sep 1999
Location: Greenville, South Cackalack
Posts: 20,610
Re: Why not just fix the site?

Originally Posted by Nick Danger View Post
Have you addressed the underlying problem?

https://forum.dvdtalk.com/dvd-review...l#post13400886
My copy of the codebase is extremely old, but it's a simple fix. In login/post.php, instead of:

Code:
  if (is_array($dailyReviews))
  {
     ... 
  }
Change it to:

Code:
  if (is_array($dailyReviews) && count($dailyReviews))
  {
     ... 
  }
  else
  {
     die("Nothing to post!\n");

     // Or, alternatively, just a plain ol' exit;
  }
I get the sense that the site and forum are what they are, and unless something truly critical is getting in the way of usability, it's not going to be updated or fixed.

Last edited by Adam Tyner; 09-03-18 at 08:31 AM.
Adam Tyner is offline  
Old 09-03-18, 08:17 AM
  #108  
Challenge Guru & Comic Nerd
 
Trevor's Avatar
 
Join Date: Apr 1999
Location: spiritually, Minnesota
Posts: 33,795
Re: Why not just fix the site?

Why are we worried about fixing a non-problem? The blank threads are actually useful, verifying that there are no new reviews that morning.
Trevor is offline  
Old 09-03-18, 08:21 AM
  #109  
DVD Talk Reviewer/ Admin
 
Adam Tyner's Avatar
 
Join Date: Sep 1999
Location: Greenville, South Cackalack
Posts: 20,610
Re: Why not just fix the site?

Originally Posted by Trevor View Post
Why are we worried about fixing a non-problem? The blank threads are actually useful, verifying that there are no new reviews that morning.
That could be better accounted for as well. Again, instead of:

Code:
  if (is_array($dailyReviews))
  {
       ...
  }
Use:

Code:
  if (is_array($dailyReviews) && count($dailyReviews))
  {
       ...
  }
  else
  {
       $post = "No new reviews have been published today.  Sorry!";
  }
Adam Tyner is offline  
Old 09-03-18, 09:18 AM
  #110  
Challenge Guru & Comic Nerd
 
Trevor's Avatar
 
Join Date: Apr 1999
Location: spiritually, Minnesota
Posts: 33,795
Re: Why not just fix the site?

Why can’t we just put Adam in charge?
Trevor is offline  
Old 09-03-18, 10:06 AM
  #111  
Moderator
Thread Starter
 
story's Avatar
 
Join Date: Mar 2000
Location: Hope.
Posts: 8,047
Re: Why not just fix the site?

"Why not just fix the site? (Why can’t we just put Adam in charge?)" could make for a good thread title change.
story is online now  
Old 09-03-18, 11:58 AM
  #112  
DVD Talk Hall of Fame
 
Join Date: Apr 2001
Location: East of Ypsi
Posts: 8,891
Re: Why not just fix the site?

Originally Posted by Trevor View Post
Why canít we just put Adam in charge?
Iíve been thinking this for years.
auto is offline  
Old 09-03-18, 11:58 AM
  #113  
DVD Talk Legend
 
hdnmickey's Avatar
 
Join Date: Jul 2014
Location: Cygnus
Posts: 12,521
Re: Why not just fix the site?

Originally Posted by Trevor View Post
Why canít we just put Adam in charge?
Far too much liberal bias?
hdnmickey is offline  
Old 11-18-18, 07:16 AM
  #114  
DVD Talk Legend
 
Nick Danger's Avatar
 
Join Date: Mar 2001
Location: Albuquerque
Posts: 21,321
Re: Why not just fix the site?

Originally Posted by Trevor View Post
Why are we worried about fixing a non-problem? The blank threads are actually useful, verifying that there are no new reviews that morning.
It was an experiment to see how responsive IB would be. In December 2017, IByen asked for examples so they could fix a bug that Adam says can be handled with one line of code. Today, eleven months later, another blank thread was posted.

https://forum.dvdtalk.com/dvd-review...l#post13445934

I'm done with the experiment.
Nick Danger is offline  
Old 11-18-18, 08:58 AM
  #115  
Challenge Guru & Comic Nerd
 
Trevor's Avatar
 
Join Date: Apr 1999
Location: spiritually, Minnesota
Posts: 33,795
Re: Why not just fix the site?

Yep, dozens of those blank threads in the past year. There are almost a dozen blank threads in that forum’s first page right now. Possible easy and quite useful fix offered by Adam over two months ago. IB response?
Trevor is offline  
Old 11-19-18, 10:56 AM
  #116  
Administrator
 
Join Date: Sep 2015
Posts: 403
Re: Why not just fix the site?

The blank threads are an indication of no new reviews being posted for that day, just as Trevor said. The reason it has not been "fixed" is because it is not a bug.
IBJoel is offline  
Old 11-19-18, 11:01 AM
  #117  
DVD Talk Reviewer/ Admin
 
Adam Tyner's Avatar
 
Join Date: Sep 1999
Location: Greenville, South Cackalack
Posts: 20,610
Re: Why not just fix the site?

As the person who originally wrote that script, it is a bug. The blank threads don’t even have titles to click on.
Adam Tyner is offline  
Old 11-19-18, 11:02 AM
  #118  
DVD Talk Hall of Fame
 
Join Date: Jan 2001
Location: MA
Posts: 9,952
Re: Why not just fix the site?

Originally Posted by IBJoel View Post
The blank threads are an indication of no new reviews being posted for that day, just as Trevor said. The reason it has not been "fixed" is because it is not a bug.
So you're saying they're a "feature"?
Noonan is offline  
Old 11-19-18, 11:10 AM
  #119  
Challenge Guru & Comic Nerd
 
Trevor's Avatar
 
Join Date: Apr 1999
Location: spiritually, Minnesota
Posts: 33,795
Re: Why not just fix the site?

The new definition of ‘facts’ is having a trickle down effect on the country. A way to fix it was detailed by Adam months ago. It’d be a nice fix for the community, and looks pretty simple. Can you either fix it, or tell us that some technical reason prohibits it?
Trevor is offline  
Old 11-19-18, 11:16 AM
  #120  
DVD Talk Reviewer/ Admin
 
Adam Tyner's Avatar
 
Join Date: Sep 1999
Location: Greenville, South Cackalack
Posts: 20,610
Re: Why not just fix the site?

I can stop the blank threads from being created. The cron was wiped out during a server change a few years back, so I’m executing these scripts remotely from my own server. I can’t update the code, but I control when things run. I can have a script check the RSS feed for new reviews and only execute the daily review script when needed.

That won’t fix the other issue where Ultra HD Blu-ray reviews don’t appear in the list. Maybe I can write something to simulate a login and create these threads differently.
Adam Tyner is offline  
Old 11-19-18, 11:19 AM
  #121  
DVD Talk Hall of Fame
 
Join Date: Jan 2001
Location: MA
Posts: 9,952
Re: Why not just fix the site?

That seems like a lot of effort for something that isn't a bug.
Noonan is offline  
Old 11-19-18, 01:19 PM
  #122  
DVD Talk Reviewer/ Admin
 
Adam Tyner's Avatar
 
Join Date: Sep 1999
Location: Greenville, South Cackalack
Posts: 20,610
Re: Why not just fix the site?

I have an improved daily recap system in place now.

Example with review content
Example without review content
Adam Tyner is offline  
Old 11-19-18, 01:42 PM
  #123  
Challenge Guru & Comic Nerd
 
Trevor's Avatar
 
Join Date: Apr 1999
Location: spiritually, Minnesota
Posts: 33,795
Re: Why not just fix the site?

Thank you Adam. Joel, pay the man.
Trevor is offline  
Old 11-19-18, 01:48 PM
  #124  
Premium Member
 
The Cow's Avatar
 
Join Date: Jan 2000
Location: Grazing in a field somewhere...
Posts: 20,459
Re: Why not just fix the site?

While we're at it... There's a nice "Buy Stuff Here" link at the top-right corner of the site (link below). Most of the links on that page are dead and have been for a long time. If there are actually some affiliate links that work, it would be nice to update that page (get rid of the dead crap), and maybe promote that once in a while to help with revenue.

https://www.dvdtalk.com/support.html
The Cow is offline  
Old 11-20-18, 01:01 PM
  #125  
Administrator
 
Join Date: Sep 2015
Posts: 403
Re: Why not just fix the site?

Originally Posted by The Cow View Post
While we're at it... There's a nice "Buy Stuff Here" link at the top-right corner of the site (link below). Most of the links on that page are dead and have been for a long time. If there are actually some affiliate links that work, it would be nice to update that page (get rid of the dead crap), and maybe promote that once in a while to help with revenue.

https://www.dvdtalk.com/support.html
I'll go through those links today/tomorrow and let tech know which ones to remove. I also opened an official tech ticket for the zero reviews and 4K reviews issues, so that can be handled with a little more oomph.
IBJoel is offline  

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are Off
Pingbacks are Off
Refbacks are Off


Thread Tools
Search this Thread

Archive Advertising Cookie Policy Privacy Statement Terms of Service

Copyright © 2018 MH Sub I, LLC dba Internet Brands. All rights reserved. Use of this site indicates your consent to the Terms of Use.